[fix](iceberg)Fix count(*) error with dangling delete problem #44039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
wuwenchi
changed the title
Contributor
Author
|
run buildall |
morningman
approved these changes
Nov 15, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 18, 2024
### What problem does this PR solve? Prevent 'dangling delete' problem after `rewrite_data_files` action. ref: https://iceberg.apache.org/docs/nightly/spark-procedures/#rewrite_position_delete_files. Because we don’t know whether the user has performed a rewrite operation, `total-records` will only be used directly when equalitydelete and positiondelete are both 0. Issue Number: close #42240
github-actions bot
pushed a commit
that referenced
this pull request
Nov 18, 2024
### What problem does this PR solve? Prevent 'dangling delete' problem after `rewrite_data_files` action. ref: https://iceberg.apache.org/docs/nightly/spark-procedures/#rewrite_position_delete_files. Because we don’t know whether the user has performed a rewrite operation, `total-records` will only be used directly when equalitydelete and positiondelete are both 0. Issue Number: close #42240
Closed
Closed
16 tasks
morningman
added a commit
that referenced
this pull request
Dec 15, 2025
…h down (#58889) ### What problem does this PR solve? Related PR: #44039 Problem Summary: In #44039, we disable the count push down to iceberg table if it has position delete file, because there may be dangling delete file that will cause the statistics info incorrect. This PR add a new session variable `ignore_iceberg_dangling_delete`, default is false, when set to true, Doris will ignore the dangling delete issue and do count push down for iceberg table, add user should take care of the result.
morningman
added a commit
to morningman/doris
that referenced
this pull request
Dec 16, 2025
…h down (apache#58889) Related PR: apache#44039 Problem Summary: In apache#44039, we disable the count push down to iceberg table if it has position delete file, because there may be dangling delete file that will cause the statistics info incorrect. This PR add a new session variable `ignore_iceberg_dangling_delete`, default is false, when set to true, Doris will ignore the dangling delete issue and do count push down for iceberg table, add user should take care of the result.
morningman
added a commit
to morningman/doris
that referenced
this pull request
Dec 16, 2025
…h down (apache#58889) Related PR: apache#44039 Problem Summary: In apache#44039, we disable the count push down to iceberg table if it has position delete file, because there may be dangling delete file that will cause the statistics info incorrect. This PR add a new session variable `ignore_iceberg_dangling_delete`, default is false, when set to true, Doris will ignore the dangling delete issue and do count push down for iceberg table, add user should take care of the result.
morningman
added a commit
to morningman/doris
that referenced
this pull request
Dec 22, 2025
…h down (apache#58889) Related PR: apache#44039 Problem Summary: In apache#44039, we disable the count push down to iceberg table if it has position delete file, because there may be dangling delete file that will cause the statistics info incorrect. This PR add a new session variable `ignore_iceberg_dangling_delete`, default is false, when set to true, Doris will ignore the dangling delete issue and do count push down for iceberg table, add user should take care of the result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Prevent 'dangling delete' problem after
rewrite_data_filesaction.ref: https://iceberg.apache.org/docs/nightly/spark-procedures/#rewrite_position_delete_files.
Because we don’t know whether the user has performed a rewrite operation,
total-recordswill only be used directly when equalitydelete and positiondelete are both 0.Issue Number: close #42240
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)